Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: sizing of workspaceAdd #3821

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fstoe
Copy link

@fstoe fstoe commented Nov 28, 2023

When using the M3 Viewer with the workspaceControlPanel set to false and placed next to a custom sidebar (allowing custom actions and triggering the Mirador catalog view), the fixed sizing of the drawer component and the workspaceAdd div results in the drawer overlapping the sidebar

oldBehavoirWithoutFix_cutupsidebar.webm
customSidebar_fixed.webm

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04c5b67) 92.49% compared to head (143452b) 92.53%.
Report is 11 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3821      +/-   ##
==========================================
+ Coverage   92.49%   92.53%   +0.04%     
==========================================
  Files         201      201              
  Lines        3465     3471       +6     
==========================================
+ Hits         3205     3212       +7     
+ Misses        260      259       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants