Video support with MUI5 React 17 #3889
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSDReferences is a list of ref to OpenSeadragon instances, used in Mirador as an image viewer. This commit exposes a VideoViewerReferences, to allows the annotations plugins to get video canvas dimensions and DOM element + removed build warning + disable "prepare" script to speed up build
- dont ignore package-lock (needed for npm ci) - use puppeteer container - use junit for proper gitlab tests reports integration - chrome without sandbox to not require SYS_ADMIN docker cap (cf https://pptr.dev/guides/docker)
babel.config.json: comment was false, it was not a warning ignored when building dependencies; but an option that babel expects to be at the same value for these 3 plugins cf this commit from mirador original repo : ProjectMirador@c79d878 AnnotationItem.js: cf issue ProjectMirador#5
Expose VideoViewerReferences like OSDReferences See merge request iiif/mirador-video-annotation!1
Integrate upstream tests into gitlab ci Closes #4 See merge request iiif/mirador-video-annotation!4
Expose VideoViewerReferences like OSDReferences See merge request iiif/mirador-video-annotation!5
- build before integration tests - also logs tests results in job output - remove online google fonts to speed up tests - run test serially to avoid timeouts (cf https://github.com/smooth-code/jest-puppeteer#running-puppeteer-in-ci-environments)
+ remove unwanted property
- use Manifesto Utils.parseManifest to feed data to component - add integrations tests for captions - remove component captions tests (cf ProjectMirador#13) - extend expect-puppeteer timeout to 2s
Fix CI configuration Closes ProjectMirador#6 See merge request iiif/mirador-video-annotation!6
Fix VideoViewer component tests Closes ProjectMirador#9 See merge request iiif/mirador-video-annotation!7
For a ref to video size/position, use AnnotationsOverlayVideo canvas instead of video element + always show this overlay, even if there is no annotations to display
…deo' Adapt API for edition of annotations on Video Closes ProjectMirador#15 See merge request iiif/mirador-video-annotation!8
- read all body to find images - show both FragmentSelector and SVG Selector
…ary and opening side to side
Creating component for manifest detail
…ideo' WIP thumbnail on accordion. See merge request iiif/mirador-video-annotation!17
Reorganize import for MUI5
Theme, style and classes migrating
Theme, style and classes migrating
…n or saving annotation)
…-video-stable' Fix ref forwarding from Mirador to Mirador CanvasAnnotationPlugin See merge request iiif/mirador/mirador-video!20
geourjoa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR is to add support for annotated videos into Mirador.
An example of such a video is given in this Manifest :
https://dzkimgs.l.u-tokyo.ac.jp/videos/cat2020/manifest.json
We started from the work done at Tokyo University :
https://github.com/2SC1815J/mirador
We now merged the recent updates to React 17 and MUI5 and plan to follow up on React 18.
A demo instance is available with a pre-release of an annotation plugin supporting video too.
https://scene.tetras-libre.fr/
Two tests are failing at the moment and I might need help to fix this.
Please let me know if a merge could happen, maybe when you will be less busy with React updates and all.
Best regards :-)