Skip to content

Commit

Permalink
Show disappointed elephant if web UI crashes (mastodon#10275)
Browse files Browse the repository at this point in the history
* Do not crash the whole UI when loading an invalid column

* Add error boundary component to catch Web UI crashes

* Add stack trace on supported browsers

* Add component stack info, pre-format everything for github

* Make “Reload” a clickable link that calls window.location.reload()

* Remove elephant friend from error boundary, make title stand out more

* Simplify error boundary to only a graphic
  • Loading branch information
Gargron authored and hiyuki2578 committed Oct 2, 2019
1 parent f79e432 commit f96d5aa
Show file tree
Hide file tree
Showing 3 changed files with 48 additions and 1 deletion.
39 changes: 39 additions & 0 deletions app/javascript/mastodon/components/error_boundary.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import React from 'react';
import PropTypes from 'prop-types';
import illustration from '../../images/elephant_ui_disappointed.svg';

export default class ErrorBoundary extends React.PureComponent {

static propTypes = {
children: PropTypes.node,
};

state = {
hasError: false,
stackTrace: undefined,
componentStack: undefined,
}

componentDidCatch(error, info) {
this.setState({
hasError: true,
stackTrace: error.stack,
componentStack: info && info.componentStack,
});
}

render() {
const { hasError } = this.state;

if (!hasError) {
return this.props.children;
}

return (
<div>
<img src={illustration} alt='' />
</div>
);
}

}
5 changes: 4 additions & 1 deletion app/javascript/mastodon/containers/mastodon.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { connectUserStream } from '../actions/streaming';
import { IntlProvider, addLocaleData } from 'react-intl';
import { getLocale } from '../locales';
import initialState from '../initial_state';
import ErrorBoundary from '../components/error_boundary';

const { localeData, messages } = getLocale();
addLocaleData(localeData);
Expand Down Expand Up @@ -75,7 +76,9 @@ export default class Mastodon extends React.PureComponent {
return (
<IntlProvider locale={locale} messages={messages}>
<Provider store={store}>
<MastodonMount />
<ErrorBoundary>
<MastodonMount />
</ErrorBoundary>
</Provider>
</IntlProvider>
);
Expand Down
5 changes: 5 additions & 0 deletions app/javascript/mastodon/features/ui/components/bundle.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@ class Bundle extends React.PureComponent {
const { fetchComponent, onFetch, onFetchSuccess, onFetchFail, renderDelay } = props || this.props;
const cachedMod = Bundle.cache.get(fetchComponent);

if (fetchComponent === undefined) {
this.setState({ mod: null });
return Promise.resolve();
}

onFetch();

if (cachedMod) {
Expand Down

0 comments on commit f96d5aa

Please sign in to comment.