Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas model #13

Merged
merged 7 commits into from
Sep 26, 2023
Merged

Gas model #13

merged 7 commits into from
Sep 26, 2023

Commits on Sep 25, 2023

  1. Add simple gas model + gas unit converter utility 

    - Gas model is based on DIII-D valve flow(command) at steady state
- Dynamics from First-Order Plus Dead Time
- Default tuning is copied from DIII-D or made up
- Model is sensitive to gas species
- Model should be valid for building workflows using sample data
    @eldond
    eldond committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    767a869 View commit details
    Browse the repository at this point in the history

  2. Fix atoms vs electrons in var names and add more checks

    @eldond
    eldond committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    1a3f8ec View commit details
    Browse the repository at this point in the history

  3. Update handling of gas units in gas unit converter

    @eldond
    eldond committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    8a7333a View commit details
    Browse the repository at this point in the history

  4. Change the way unitful gas conversions work

    @eldond
    eldond committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    bbe643a View commit details
    Browse the repository at this point in the history

  5. Try a different way of handling unitful quantities in gas unit converter

    @eldond
    eldond committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    7bdf0c7 View commit details
    Browse the repository at this point in the history

  6. Make gas valve selector function return functions for specific models

    @eldond
    eldond committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    196d220 View commit details
    Browse the repository at this point in the history

  7. Format

    @eldond
    eldond committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    13d4b2c View commit details
    Browse the repository at this point in the history