Bug fix for dd.equilibrium.time_slice[:].profiles_2d[:].psi transpose issue #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we use sample/ITER_Lore_2296_00000/EQDSK/g002296.00200 then the geqdsk file has unequal dimensions for the r and z grid. For this test case, geqdsk_to_imas test fails. This shows that there might be a transpose issue in setting up of dd.equilibrium.time_slice[:].profiles_2d[:].psi Please verify this test and fix.
If we use sample/ITER_Lore_2296_00000/EQDSK/g002296.00200 then the geqdsk file has unequal dimensions for the r and z grid. For this test case, geqdsk_to_imas test fails. This shows that there might be a transpose issue in setting up of dd.equilibrium.time_slice[:].profiles_2d[:].psi Please verify this test and fix.
…jl into bug_fix_req Rebased to dev to get the [PR#14](#14)
anchal-physics
added a commit
that referenced
this pull request
Sep 28, 2023
Merge pull request #16 from ProjectTorreyPines/bug_fix_req
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #15 fixed in 546f5cd