Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing OMAS with IMASDD everywhere #50

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Replacing OMAS with IMASDD everywhere #50

merged 4 commits into from
Mar 25, 2024

Commits on Mar 23, 2024

  1. Replacing OMAS with IMASDD everywhere

    Tested this but got following error:
    ```
    (base) gupta@F-CJXNMY7L7 SD4SOLPS.jl % julia --project test/runtests.jl
    Test Summary:         | Pass  Total  Time
    lightweight_utilities |    4      4  1.0s
    Test Summary: | Pass  Total  Time
    actuator      |    2      2  1.7s
    core_profile_extension: Error During Test at /Users/gupta/Git/ProjectTorreyPines/SD4SOLPS.jl/test/runtests.jl:166
      Got exception outside of a @test
      UndefVarError: `gradient` not defined
      Stacktrace:
       [1] extrapolate_core(edge_rho::Vector{Float64}, edge_quantity::Vector{Float64}, rho_output::Vector{Float64})
         @ SD4SOLPS ~/Git/ProjectTorreyPines/SD4SOLPS.jl/src/supersize_profile.jl:58
       [2] macro expansion
         @ ~/Git/ProjectTorreyPines/SD4SOLPS.jl/test/runtests.jl:171 [inlined]
       [3] macro expansion
         @ /Applications/Julia-1.9.app/Contents/Resources/julia/share/julia/stdlib/v1.9/Test/src/Test.jl:1498 [inlined]
       [4] top-level scope
         @ ~/Git/ProjectTorreyPines/SD4SOLPS.jl/test/runtests.jl:168
       [5] include(mod::Module, _path::String)
         @ Base ./Base.jl:457
       [6] exec_options(opts::Base.JLOptions)
         @ Base ./client.jl:307
       [7] _start()
         @ Base ./client.jl:522
    Test Summary:          | Error  Total  Time
    core_profile_extension |     1      1  0.5s
    ERROR: LoadError: Some tests did not pass: 0 passed, 0 failed, 1 errored, 0 broken.
    in expression starting at /Users/gupta/Git/ProjectTorreyPines/SD4SOLPS.jl/test/runtests.jl:165
    ```
    
    For testing, following versions of the pacjages were used (these are the points where IMASDD was used instead of OMAS):
    GGDUtils: ProjectTorreyPines/IMASggd.jl@b11ad15
    SOLPS2IMAS: ProjectTorreyPines/SOLPS2imas.jl@f843e6a
    
    The main issue is that OMAS.gradient() function is defined in https://github.com/ProjectTorreyPines/OMAS.jl/blob/master/src/math.jl
    but no such function exists in IMASDD.
    anchal-physics committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    3597a61 View commit details
    Browse the repository at this point in the history
  2. Using readg() with set_time & conformed to IMASDD

    Using set_time for sample files where description is not in the
    standard format.
    
    Changes were made in the code to use ismissing in places to conform to
    requirements of IMASDD.
    
    In record_regular_mesh!(), the deepcopy of each element was replaced
    with deepcopy of the entire grid subset to improve speed.
    
    The test runtests.jl was updated to reflect the changes.
    
    All tests pass now with following versions:
    
    JuliaFusion/EFIT.jl@8580ca8
    ProjectTorreyPines/IMASdd.jl@6a6968a
    ProjectTorreyPines/IMASggd.jl@b11ad15
    ProjectTorreyPines/SOLPS2imas.jl@f843e6a
    
    Note that EFIT version that was used has not been merged with its
    master branch yet at the time of this test.
    
    In conclusion, in future, OMAS can be removed now.
    anchal-physics committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    864319e View commit details
    Browse the repository at this point in the history
  3. Putting back OMAS

    anchal-physics committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    c7c3c1e View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Configuration menu
    Copy the full SHA
    c614b8b View commit details
    Browse the repository at this point in the history