Stop using Package@swift-version syntax to support SPM in Xcode 13. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxcl
added a commit
that referenced
this pull request
Sep 20, 2021
Merged
mxcl
added a commit
that referenced
this pull request
Sep 20, 2021
mxcl
added a commit
that referenced
this pull request
Sep 20, 2021
mxcl
added a commit
that referenced
this pull request
Sep 20, 2021
mxcl
added a commit
that referenced
this pull request
Sep 20, 2021
mxcl
added a commit
that referenced
this pull request
Sep 20, 2021
|
I used #17 since it doesn’t kill 4.0/4.2 compat. |
|
Sure, whatever you feel is best! Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that Xcode 13 (as of Xcode 13 Release Candidate at least) stopped recognizing Package@swift-version syntax. When resolving dependencies, SPM uses Package.swift instead of Package@4.2.swift file, causing build failures in Xcode 13.
This PR replaces contents of Package.swift file with contents of Package@4.2.swift file, allowing SPM to succeed.
This probably drops some old Xcodes, but since
swift-tools-version:4.2is already three years old, and old Xcodes cannot submit to AppStore(at least on iOS), this seems safe to remove.