Ensure selection is definitely collapsed - fixes Blink Shadow DOM bug #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Merged and followed up with 1d6df3e (since browser don't actually support multiple selections, checking range 0 is enough). |
|
@marijnh yeah I didn't quite know what the deal was with multiple ranges - thanks for clearing that up :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks that a selection's ranges are all collapsed instead of just relying on the
isCollapsedproperty. This can occur in both v0 and v1 Shadow DOM implementations in Chrome - see this Blink bug.Fixes this issue