Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve button contrast #317

Closed
lidel opened this issue Oct 31, 2019 · 6 comments
Closed

Improve button contrast #317

lidel opened this issue Oct 31, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@lidel
Copy link
Collaborator

lidel commented Oct 31, 2019

@ericronne mentioned this problem in WebUI and now I cannot unsee it everywhere 👀 💦

Problem

Buttons have low contrast and look "disabled" and literally look the same when "disabled" and "enabled":

  • Disabled

    • off-2019-10-31--15-23-14
  • Enabled + hover

    • on-2019-10-31--15-23-33
    • 2019-10-31--15-47-03

Proposed change

It would be useful to change background of "enabled" buttons to something like bg-navy from ipfs-css:

Screenshot_2019-10-31 ProtoSchool

@lidel lidel added the enhancement New feature or request label Oct 31, 2019
@terichadbourne
Copy link
Member

@lidel Do you remember where you were / what you were doing when you got a disabled button that looks like this? We do have at least one case where we disable it (when you haven't yet uploaded files, but that case contains a hover state with a message that makes it abundantly clear why you can't click.

(I'm open to color changes also, just want to make sure we also know when/why it's happening in case there's other stuff to address.

@ericronne
Copy link
Collaborator

Fyi disabled buttons don't have to meet the 4.5:1 guideline mark.
https://www.w3.org/TR/WCAG21/#contrast-minimum

@lidel
Copy link
Collaborator Author

lidel commented Nov 1, 2019

@terichadbourne it was /#/regular-files-api/05 (i cropped the screenshot, below is full version of disabled button):

2019-11-01--13-34-45

What I meant is that disabled button looks kinda ok, the problem is contrast of active ones :)

@ericronne
Copy link
Collaborator

I'd recommend that the inactive button color be a tint of the active button, rather than a different color altogether. So if the submit button will be blue when active, it could look something like this when inactive (alphaed back blue for the fill, alphaed back white text):
y

@terichadbourne
Copy link
Member

Thanks for the suggestions @lidel & @ericronne. @dominguesgm could you take a stab at this one this week?

@terichadbourne
Copy link
Member

closed via #342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants