chore: improved button disabled status #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebateira
approved these changes
Jan 9, 2020
|
Thanks @dominguesgm! I believe @ericronne's suggestion for the disabled color scheme was meant to coordinate with @lidel's suggestion of using |
|
Sure, just tried it. Let me know if you prefer this look.
If so, I'll commit the changes. |
|
@dominguesgm good to go. just commit the changes and we can merge 🎉 |
terichadbourne
approved these changes
Jan 10, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated disabled button styles to match @ericronne's recommendation in #317.
One thing to note is that as the button is disabled in the loading state, it will show up with the new disabled style. We need to discuss whether this is appropriate or not @terichadbourne @zebateira.