feat(GODT-2510): Direct SQLite3 #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LBeernaertProton
force-pushed
the
feat/GODT-2510-sqlite
branch
2 times, most recently
from
35e71bb
to
4f5899e
Compare
cuthix
reviewed
Jun 13, 2023
cuthix
reviewed
Jun 13, 2023
cuthix
reviewed
Jun 13, 2023
cuthix
reviewed
Jun 13, 2023
cuthix
reviewed
Jun 13, 2023
cuthix
reviewed
Jun 13, 2023
xmichelo
previously approved these changes
Jun 13, 2023
xmichelo
reviewed
Jun 13, 2023
cuthix
reviewed
Jun 13, 2023
LBeernaertProton
force-pushed
the
feat/GODT-2510-sqlite
branch
from
4f5899e
to
32f8246
Compare
DB implementation using SQLite3. This current version is feature complete with the ent implementation. The only noticeable difference is the addition of the db version table. The new database is now the default, but we will still run tests on CI to compare behavior against old implementation until it is completely removed.
LBeernaertProton
force-pushed
the
feat/GODT-2510-sqlite
branch
from
32f8246
to
60e356d
Compare
This test fails a lot on CI due to some events not being processed at the right time. This will be checked later with GODT-2688.
LBeernaertProton
force-pushed
the
feat/GODT-2510-sqlite
branch
from
d88f5cf
to
93b77d2
Compare
cuthix
approved these changes
Jun 13, 2023
|
🎉 This PR is included in version 0.17.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DB implementation using SQLite3. This current version is feature complete with the ent implementation. The only noticeable difference is the addition of the db version table.
The new database is now the default, but we will still run tests on CI to compare behavior against old implementation until it is completely removed.