feat(GODT-2803): Allow access to IMAP state from connector #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update connector interface so that it has access to the internal IMAP state of Gluon. Similar to the DB design, there are modifiers for writing and reading from this state. This is required so that it remains compatible with how we are currently handling the database access code. Finally, The `StateConnectorInterface` has been updated to return state updates for all actions, since it is now possible for connectors to apply IMAP state changes with each operation. Similar to previous changes, those state updates need to be kept around until the transaction has successfully committed. This patch includes 3 example functions which cover the cases of reading, writing without updates and writing with updates. More should be added in the future as needed.
cuthix
approved these changes
Aug 14, 2023
cuthix
pushed a commit
to ProtonMail/proton-bridge
that referenced
this pull request
Sep 15, 2023
Update to latest Gluon to allow access to the database for bridge. The cache is placed in a `SharedCache` type to ensure that we respect calls to `Connector.Close`. In theory, this should never trigger an error, but this way we can catch it if it happens. ProtonMail/gluon#391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update connector interface so that it has access to the internal IMAP state of Gluon.
Similar to the DB design, there are modifiers for writing and reading from this state. This is required so that it remains compatible with how we are currently handling the database access code.
Finally, The
StateConnectorInterfacehas been updated to return state updates for all actions, since it is now possible for connectors to apply IMAP state changes with each operation. Similar to previous changes, those state updates need to be kept around until the transaction has successfully committed.This patch includes 3 example functions which cover the cases of reading, writing without updates and writing with updates. More should be added in the future as needed.