Lower Argon2 memory parameter in S2K test vector #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the memory exponent parameter in the argon2 s2k test vector from 22 to 16. Reduces the memory requirement, which caused failures on 32-bit platforms.
twiss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #177, which reported that the s2k
TestParseIntoParamstest fails on 32-bit platforms.The issue is that the argon2 memory exponent parameter in the test case causes the argon2 implementation to fail on 32-bit platforms on slice creation.
This pull request changes the memory exponent parameter in the argon2 s2k test vector from 22 to 16, thus, reducing the memory requirement for the test case.