Allow empty Key Flags subpackets #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubux
approved these changes
Jul 8, 2024
| @@ -518,11 +518,10 @@ func parseSignatureSubpacket(sig *Signature, subpacket []byte, isHashed bool) (r | |||
| } | |||
| case keyFlagsSubpacket: | |||
| // Key flags, section 5.2.3.21 | |||
There was a problem hiding this comment.
Not for this MR but rather for a future refactor. I noticed that RFC4880 has different sections than the crypto-refresh. Thus, it can be a bit confusing to reference sections in the doc comments.
There was a problem hiding this comment.
Yeah, I agree. In general we should update all the references once RFC9580 comes out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow parsing empty Key Flags subpackets.
This is allowed by the spec, which says:
And it can be useful to explicitly say that a primary key is not allowed to be used for any purpose (except certifying subkeys), for example.