Update to GopenPGP v3 #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wussler
reviewed
Nov 30, 2023
There was a problem hiding this comment.
Hi @lubux, great design - mostly minor cosmetic comments sprinkled with a couple possible bugs.
Before merging, we should compile this for go-mobile and check that there is no method being excluded due to some silly constraints.
|
Hey @wussler! Appreciate your thoughtful review and the detailed suggestions. I've taken care of most of them and added comments where needed. If there's anything else that requires attention, let me know. Thanks again! |
wussler
approved these changes
Dec 6, 2023
lubux
force-pushed
the
v3
branch
7 times, most recently
from
4c39871
to
2108fcd
Compare
|
This PR is good to go for me. I'll finish reviewing go-crypto before we merge both. |
lubux
force-pushed
the
v3
branch
3 times, most recently
from
e526db2
to
80762a9
Compare
In GopenPGP v3, the verified data reader did not return a verification result if no verification keys were provided during decryption. This PR ensures that a verification result is returned even when no verification keys are provided. The verification result indicates that there were no matching verification keys. Further updates go-crypto to v1.1.0-alpha.2.
* Add parsing and serializing interfaces for keyrings * Make error check more compact
* feat(armor): Armor checksum handling according to the crypto refresh * docs(readme): Add info about v2 support * refactor(armor): Improve checksum naming * refactor(armor): Rename global checksum setting variable
* feat(profiles): Remove pre-set profile name strings and refactor - Remove profile name map - Rename Crypto Refresh profile to RFC9580 - Remove GnuPG profile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GopenPGP v3 is a complete redesign of the GopenPGP library an introduces a new API.