Upgrade to OpenPGP.js v6 #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larabr
force-pushed
the
openpgpjs-v6
branch
2 times, most recently
from
1edf643
to
280d91c
Compare
larabr
force-pushed
the
openpgpjs-v6
branch
3 times, most recently
from
00afbcb
to
f876d28
Compare
larabr
force-pushed
the
openpgpjs-v6
branch
3 times, most recently
from
53fde95
to
c4f1cde
Compare
larabr
commented
Dec 19, 2023
larabr
force-pushed
the
openpgpjs-v6
branch
2 times, most recently
from
0571f71
to
af77e43
Compare
larabr
force-pushed
the
openpgpjs-v6
branch
4 times, most recently
from
7d94613
to
02e3c15
Compare
larabr
force-pushed
the
openpgpjs-v6
branch
3 times, most recently
from
3445257
to
eb8e9f6
Compare
larabr
force-pushed
the
openpgpjs-v6
branch
2 times, most recently
from
53e68ef
to
0d033a1
Compare
This commit only points to the new version, making sure the module and test compiles, but makes no logic changes to e.g. add support to new key algos/formats.
OpenPGP.js v6 drops support for platforms without native BigInts
Adding support for TS v5.
…erated key prefs OpenPGP.js v5 does not support sha3, so we should not include it in the key prefs until the full v6 integration in the webapps and mobile.
…ions Also, rename `MaybeStream` to `MaybeWebStream` to help differentiate it from `openpgpjs.MaybeStream`, which can also be a NodeStream.
…lic keys (default to `config.ignoreSEIPDv2FeatureFlag: true`) We want to avoid generating SEIPDv2 messages until support is rolled out to other platforms, in case e.g. some users have already imported v4 keys with SEIPDv2 feature flags. This change affects `encryptMessage` and `generateSessionKeys` when `encryptionKeys` are given (rather than `passwords`).
larabr
force-pushed
the
openpgpjs-v6
branch
from
09805f1
to
52b4467
Compare
To test latest browser versions
No longer used since removal of legacy message decryption support
To avoid issues when using e.g. Babel/SWC/Vite in the web-app tests (https://typescript-eslint.io/blog/consistent-type-imports-and-exports-why-and-how#isolated-module-transpilation)
larabr
force-pushed
the
openpgpjs-v6
branch
from
473876f
to
1a65851
Compare
larabr
force-pushed
the
openpgpjs-v6
branch
5 times, most recently
from
d449e8b
to
d4a1039
Compare
Unfortunately Windows gives issues with Firefox not capturing.
We still guard against inclusion for v4 keys, since not all clients support the algorithm
…e being used at all Through `checkKeyCompatibility` errors.
larabr
force-pushed
the
openpgpjs-v6
branch
2 times, most recently
from
e595994
to
7919a1a
Compare
larabr
force-pushed
the
openpgpjs-v6
branch
2 times, most recently
from
c22147b
to
04ba4b2
Compare
twiss
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-breaking changes:
Breaking changes:
exportsonly (if this is too problematic, we could temporarily add legacy entrypoints to that dependency, since we currently use a fork).checkKeyCompatibilitywill reject v5 keysTODO:
checkKeyStrength) (allow for v6 keys only)dateinputs mandatory?