Fix forwarding helpers: accept date option and use serverTime instead of local time by default
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiss
approved these changes
Mar 12, 2024
…ardingKey` to accept a date or use serverTime The functions now accept a date as input, and fallback to the server time by default. Previously, the functions would use local time to filter encryption keys, meaning wrong results might be returned with local time in the future compared to key creation time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generateForwardingMaterial,doesKeySupportForwarding, andisForwardingKeynow accept a date as input, and fallback to the server time by default.Previously, the functions would use local time to filter encryption keys, meaning wrong results might be returned with local time in the future compared to key creation time.