FREQ is mandatory in the RRule #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinbonneaud
force-pushed
the
feat/validate-freq
branch
from
bd4c7a9
to
3bcc640
Compare
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
============================================
+ Coverage 98.86% 98.88% +0.01%
- Complexity 1869 1870 +1
============================================
Files 65 65
Lines 5305 5307 +2
============================================
+ Hits 5245 5248 +3
+ Misses 60 59 -1
Continue to review full report at Codecov.
|
ThHareau
reviewed
Jan 30, 2020
| @@ -9,6 +9,18 @@ | |||
|
|
|||
| class RRuleIteratorTest extends TestCase | |||
| { | |||
| /** | |||
| * @expectedException \Sabre\VObject\InvalidDataException | |||
There was a problem hiding this comment.
Could you use instead
$this->expectException(\Sabre\VObject\InvalidDataException::class);
The annotation has been removed in PHPUnit 8 (and deprecated in PHPUnit 7). Sabre/vobject has already begin to move to PHPUnit 8, it will be an issue later
There was a problem hiding this comment.
You're right, just updated
ThHareau
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Freq property is mandatory in a recurrence rule.
From RFC
https://tools.ietf.org/html/rfc5545#section-3.3.10
Fixes CALENDAR-643