Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate BYMONTHDAY #12

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Validate BYMONTHDAY #12

merged 1 commit into from
Jan 30, 2020

Conversation

valentinbonneaud
Copy link
Collaborator

From the RFC, the ByMonthDay parameter can only take values in [1,31] u [-31,-1]

  The BYMONTHDAY rule part specifies a COMMA-separated list of days
  of the month.  Valid values are 1 to 31 or -31 to -1.

https://tools.ietf.org/html/rfc5545#section-3.3.10

@valentinbonneaud valentinbonneaud changed the title Add test on BYMONTHDAY Validate BYMONTHDAY Jan 30, 2020
@codecov-io
Copy link

codecov-io commented Jan 30, 2020

Codecov Report

Merging #12 into master will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #12      +/-   ##
============================================
- Coverage     98.88%   98.87%   -0.02%     
- Complexity     1870     1875       +5     
============================================
  Files            65       65              
  Lines          5307     5313       +6     
============================================
+ Hits           5248     5253       +5     
- Misses           59       60       +1
Impacted Files Coverage Δ Complexity Δ
lib/Recur/RRuleIterator.php 99.17% <83.33%> (-0.2%) 213 <0> (+5)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 647533a...0e28a5f. Read the comment docs.

@valentinbonneaud valentinbonneaud merged commit 2fe3a9a into master Jan 30, 2020
@valentinbonneaud valentinbonneaud deleted the feat/test-BYMONTHDAY branch January 30, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants