Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose RRULE properties from RRuleIterator #15

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

bcaller
Copy link

@bcaller bcaller commented Jul 21, 2020

COUNT
FREQ
INTERVAL
UNTIL

@valentinbonneaud
Copy link
Collaborator

Can you add some unit tests around the new accessors?

@bcaller bcaller force-pushed the feat/expose-rrule-properties branch from a722858 to 3bf7f19 Compare July 22, 2020 09:30
@bcaller bcaller force-pushed the feat/expose-rrule-properties branch from 3bf7f19 to 44daea6 Compare July 22, 2020 09:34
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2020

Codecov Report

Merging #15 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #15   +/-   ##
=========================================
  Coverage     98.91%   98.91%           
- Complexity     1876     1880    +4     
=========================================
  Files            66       66           
  Lines          5505     5513    +8     
=========================================
+ Hits           5445     5453    +8     
  Misses           60       60           
Impacted Files Coverage Δ Complexity Δ
lib/Recur/RRuleIterator.php 99.19% <100.00%> (+0.01%) 218.00 <4.00> (+4.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca647a2...44daea6. Read the comment docs.

@valentinbonneaud valentinbonneaud merged commit b16c3e7 into master Jul 22, 2020
@valentinbonneaud valentinbonneaud deleted the feat/expose-rrule-properties branch August 5, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants