Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block invalid combinations of FREQ with BY rules #48

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

giuseppe-arcuti
Copy link
Collaborator

No description provided.

@giuseppe-arcuti giuseppe-arcuti force-pushed the fix/block-invalid-rrule branch 3 times, most recently from 1bf978b to a48e117 Compare February 28, 2022 10:39
@giuseppe-arcuti giuseppe-arcuti changed the title Block MONTHLY with BYYEARDAY Block invalid combinations of FREQ with BY rules Feb 28, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #48 (76b1a0d) into master (bf3b4c2) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #48      +/-   ##
============================================
- Coverage     98.35%   98.32%   -0.04%     
+ Complexity     1938     1935       -3     
============================================
  Files            72       66       -6     
  Lines          4688     4299     -389     
============================================
- Hits           4611     4227     -384     
+ Misses           77       72       -5     
Flag Coverage Δ
tests 98.32% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Recur/RRuleIterator.php 98.99% <100.00%> (-0.03%) ⬇️
lib/PHPUnitAssertions.php 90.00% <0.00%> (-1.31%) ⬇️
lib/Component/VCalendar.php 94.21% <0.00%> (-1.15%) ⬇️
lib/Property/FloatValue.php 96.00% <0.00%> (-0.43%) ⬇️
lib/Property/Time.php 96.96% <0.00%> (-0.40%) ⬇️
lib/Recur/RDateIterator.php 97.29% <0.00%> (-0.33%) ⬇️
lib/Parser/Json.php 96.66% <0.00%> (-0.31%) ⬇️
lib/Parser/XML.php 97.22% <0.00%> (-0.24%) ⬇️
lib/BirthdayCalendarGenerator.php 97.95% <0.00%> (-0.23%) ⬇️
lib/FreeBusyData.php 98.38% <0.00%> (-0.19%) ⬇️
... and 48 more

@valentinbonneaud
Copy link
Collaborator

For reference https://datatracker.ietf.org/doc/html/rfc5545#section-3.3.10

      The BYMONTHDAY rule part specifies a COMMA-separated list of days
      of the month.  ...
      The BYMONTHDAY rule part MUST NOT be specified when the FREQ rule
      part is set to WEEKLY.

The BYYEARDAY rule part MUST NOT be specified when the FREQ
      rule part is set to DAILY, WEEKLY, or MONTHLY.

The BYWEEKNO rule part specifies a COMMA-separated list of
      ordinals specifying weeks of the year.  ...  This rule part MUST NOT be used when the FREQ rule
      part is set to anything other than YEARLY. 

@valentinbonneaud valentinbonneaud merged commit 786c731 into master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants