[Calendar] Handle customized timezone #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
============================================
- Coverage 98.28% 98.21% -0.08%
- Complexity 1965 1983 +18
============================================
Files 76 77 +1
Lines 4379 4427 +48
============================================
+ Hits 4304 4348 +44
- Misses 75 79 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
liurxliu
force-pushed
the
feat/cal-customized-tz
branch
3 times, most recently
from
1b24f80
to
4daa7fd
Compare
valentinbonneaud
requested changes
May 30, 2022
tests/VObject/TimeZoneUtilTest.php
Outdated
| $ics = <<<ICS | ||
| BEGIN:VCALENDAR | ||
| VERSION:2.0 | ||
| PRODID:-//ical.marudot.com//iCal Event Maker X-WR-CALNAME:Victorian public holiday dates |
There was a problem hiding this comment.
Looks like there is a missing new line here
liurxliu
force-pushed
the
feat/cal-customized-tz
branch
from
4daa7fd
to
64977e1
Compare
liurxliu
force-pushed
the
feat/cal-customized-tz
branch
2 times, most recently
from
695c5fe
to
f37ec8d
Compare
liurxliu
force-pushed
the
feat/cal-customized-tz
branch
from
f37ec8d
to
06c1528
Compare
valentinbonneaud
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.