Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify TZID value for migration timezones #82

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

liurxliu
Copy link
Collaborator

@liurxliu liurxliu commented Mar 9, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Merging #82 (40bf3d9) into master (8525bea) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #82   +/-   ##
=========================================
  Coverage     98.50%   98.50%           
- Complexity     1989     1990    +1     
=========================================
  Files            77       77           
  Lines          5899     5901    +2     
=========================================
+ Hits           5811     5813    +2     
  Misses           88       88           
Flag Coverage Δ
tests 98.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/TimezoneGuesser/FindFromTimezoneIdentifier.php 94.44% <100.00%> (+0.69%) ⬆️

@chris-szu chris-szu requested review from chris-szu, giuseppe-arcuti and valentinbonneaud and removed request for chris-szu March 9, 2023 06:28
@liurxliu liurxliu force-pushed the feat/handle-migration-tz branch 4 times, most recently from dd33a08 to 626dbb8 Compare March 14, 2023 06:08
Copy link

@chris-szu chris-szu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

lib/TimeZoneUtil.php Outdated Show resolved Hide resolved
@liurxliu liurxliu merged commit 9b2bf1e into master Apr 13, 2023
@liurxliu liurxliu deleted the feat/handle-migration-tz branch April 13, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants