[Aleo ins] Update grammar based on audit. #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendyarm
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Looks good to me. All except one of the changes look like improvements.
One of the changes that is being made to match the snarkVM parser might need to be changed again because most likely the intent of the parser is something else. We will propose that as a separate change to the parser and the grammar. Specifically, the snarkVM parser allows call ... into with zero registers after the into. I think if there are no destination registers, we probably want to disallow the into. Again, I recommend merging this commit and then we will propose matching changes in snarkVM and grammars for call.
|
The issue with "dangling" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53, #54, #55, #56, #57, #58, #59, #60, #61.