-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Eliminate const
variables as such
#515
Labels
feature
A new feature.
Comments
bors bot
added a commit
that referenced
this issue
Feb 18, 2021
668: Bump rand_core from 0.6.1 to 0.6.2 r=collinc97 a=dependabot-preview[bot] Bumps [rand_core](https://github.com/rust-random/rand) from 0.6.1 to 0.6.2. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rust-random/rand/blob/master/CHANGELOG.md">rand_core's changelog</a>.</em></p> <blockquote> <h2>[0.6.2] - 2019-01-04</h2> <h3>Additions</h3> <ul> <li>Add <code>Default</code> for <code>ThreadRng</code> (<a href="https://github-redirect.dependabot.com/rust-random/rand/issues/657">#657</a>)</li> <li>Move <code>rngs::OsRng</code> to <code>rand_os</code> sub-crate; clean up code; use as dependency (<a href="https://github-redirect.dependabot.com/rust-random/rand/issues/643">#643</a>) ##BLOCKER##</li> <li>Add <code>rand_xoshiro</code> sub-crate, plus benchmarks (<a href="https://github-redirect.dependabot.com/rust-random/rand/issues/642">#642</a>, <a href="https://github-redirect.dependabot.com/rust-random/rand/issues/668">#668</a>)</li> </ul> <h3>Fixes</h3> <ul> <li>Fix bias in <code>UniformInt::sample_single</code> (<a href="https://github-redirect.dependabot.com/rust-random/rand/issues/662">#662</a>)</li> <li>Use <code>autocfg</code> instead of <code>rustc_version</code> for rustc version detection (<a href="https://github-redirect.dependabot.com/rust-random/rand/issues/664">#664</a>)</li> <li>Disable <code>i128</code> and <code>u128</code> if the <code>target_os</code> is <code>emscripten</code> (<a href="https://github-redirect.dependabot.com/rust-random/rand/issues/671">#671</a>: work-around Emscripten limitation)</li> <li>CI fixes (<a href="https://github-redirect.dependabot.com/rust-random/rand/issues/660">#660</a>, <a href="https://github-redirect.dependabot.com/rust-random/rand/issues/671">#671</a>)</li> </ul> <h3>Optimisations</h3> <ul> <li>Optimise memory usage of <code>UnitCircle</code> and <code>UnitSphereSurface</code> distributions (no PR)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rust-random/rand/commit/3a03c9eb5350e03a3f540dba2ee34e0984f2c2c2"><code>3a03c9e</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rust-random/rand/issues/1096">#1096</a> from tmandry/patch-1</li> <li><a href="https://github.com/rust-random/rand/commit/2cf5120dd5642f6bdb8d5359ddc6bb459489a2d9"><code>2cf5120</code></a> Bump to 0.6.2</li> <li><a href="https://github.com/rust-random/rand/commit/390a7b1049fa5ba1d627feaef2a1629e0e7826b4"><code>390a7b1</code></a> Fix assertions inside read_{u32,u64}_into</li> <li><a href="https://github.com/rust-random/rand/commit/6ecbe2626b2cc6110a25c97b1702b347574febc7"><code>6ecbe26</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rust-random/rand/issues/1089">#1089</a> from dhardy/work</li> <li><a href="https://github.com/rust-random/rand/commit/8821743325303e4deb6c4a6c934f0e2eb9680205"><code>8821743</code></a> Prepare 0.8.3</li> <li><a href="https://github.com/rust-random/rand/commit/fa615efd91f83fe8e56799cfa9217d67f7625fb7"><code>fa615ef</code></a> Feature gate choose_multiple_weighted on std</li> <li><a href="https://github.com/rust-random/rand/commit/22dec87aac43e0e92eb15fa85b2de6da5b3c95b7"><code>22dec87</code></a> CI: more accurate no-default-feature and nightly test targets</li> <li><a href="https://github.com/rust-random/rand/commit/6a6b9fd06dbf54538d250dfbc4c918f79daa9299"><code>6a6b9fd</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rust-random/rand/issues/1087">#1087</a> from GautierMinster/fix_uniform_int_panic_on_full_in...</li> <li><a href="https://github.com/rust-random/rand/commit/2c9085a2de8864ee327af0311f6a8e5747cf25b7"><code>2c9085a</code></a> Bump to 0.8.2 and update changelog</li> <li><a href="https://github.com/rust-random/rand/commit/4e8c7a4ca2963797d0ec414d04b6239ece905165"><code>4e8c7a4</code></a> distributions/uniform: fix panic in gen_range(0..=MAX)</li> <li>See full diff in <a href="https://github.com/rust-random/rand/compare/rand_core-0.6.1...rand_core-0.6.2">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=rand_core&package-manager=cargo&previous-version=0.6.1&new-version=0.6.2)](https://dependabot.com/compatibility-score/?dependency-name=rand_core&package-manager=cargo&previous-version=0.6.1&new-version=0.6.2) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> 672: Feature/515 eliminate const vars r=collinc97 a=gluax Resolves #515. Removes const keyword from statements. Also resolves #514. Still allows const y in function declaration of args. Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: gluaxspeed <jonathan.t.pavlik@gmail.com> Co-authored-by: gluax <jonathan.t.pavlik@gmail.com> Co-authored-by: Collin Chin <collin.chin@berkeley.edu>
bors bot
added a commit
that referenced
this issue
Feb 18, 2021
672: Feature/515 eliminate const vars r=collinc97 a=gluax Resolves #515. Removes const keyword from statements. Also resolves #514. Still allows const y in function declaration of args. Co-authored-by: gluaxspeed <jonathan.t.pavlik@gmail.com> Co-authored-by: gluax <jonathan.t.pavlik@gmail.com> Co-authored-by: Collin Chin <collin.chin@berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🚀 Feature
Currently there are three kinds of variables:
const
) -- their value is known at compile time and never changes.let
) -- their value never changes; it may or may not be known at compile time.let mut
) -- their value may change; it may or may not be known at compile time.Constant variables are not allocated in the R1CS circuit, while immutable and mutable variables are.
We could simplify the language to have just immutable (
let
) and mutable (let mut
) variables, without anyconst
variables. The compiler could automatically infer, via constant propagation and folding, which variables have values known at compile time and therefore need not be allocated in the R1CS circuit.Motivation
This could make the language simpler to learn and use.
This would also simplify type checking/inference, which would not have to worry about constancy (see issue #514).
It could potentially make the translation to R1CS slightly more complicated by having to figure out automatically which variables need not be allocated, but arguably this is something that we may want the compiler to do anyhow, so perhaps there is no downside from this standpoint.
Implementation
This would affect the Pest grammar, the ASTs, type checking/inference, and the translation to R1CS.
The text was updated successfully, but these errors were encountered: