Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Extending scope of the RFC to include proving system and curve #1072

Merged
merged 5 commits into from
Jul 2, 2021

Conversation

damirka
Copy link
Contributor

@damirka damirka commented Jun 28, 2021

Motivation

Follow up after speaking with Howard. We'd want to have proving system and curve parameters inside Leo.toml to later match based on compatibility of ps and curves.

@damirka damirka added the RFC label Jun 28, 2021
@damirka damirka self-assigned this Jun 28, 2021
@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #1072 (35660c8) into master (1083fc8) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1072      +/-   ##
==========================================
- Coverage   75.79%   75.73%   -0.06%     
==========================================
  Files         439      439              
  Lines       17803    17802       -1     
==========================================
- Hits        13493    13482      -11     
- Misses       4310     4320      +10     
Impacted Files Coverage Δ
compiler/src/expression/array/array.rs 57.14% <0.00%> (-28.58%) ⬇️
compiler/src/statement/assign/assign.rs 68.42% <0.00%> (-5.27%) ⬇️
...piler/src/statement/assign/assignee/array_index.rs 84.21% <0.00%> (-5.27%) ⬇️
asg/src/reducer/reconstructing_reducer.rs 89.14% <0.00%> (-3.17%) ⬇️
asg/src/reducer/visitor.rs 90.62% <0.00%> (-3.13%) ⬇️
compiler/src/expression/array/access.rs 48.33% <0.00%> (-2.50%) ⬇️
asg/src/reducer/visitor_director.rs 83.44% <0.00%> (-2.37%) ⬇️
asg/src/reducer/reconstructing_director.rs 92.55% <0.00%> (-2.33%) ⬇️
compiler/src/expression/expression.rs 81.25% <0.00%> (-2.09%) ⬇️
asg/src/expression/array_init.rs 74.46% <0.00%> (-1.88%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1083fc8...35660c8. Read the comment docs.

Copy link
Collaborator

@acoglio acoglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@damirka damirka changed the title [WIP, RFC] Extending scope of the RFC to include proof system and curves [WIP, RFC] Extending scope of the RFC to include proving system and curve Jun 30, 2021
@damirka damirka marked this pull request as ready for review June 30, 2021 19:12
@damirka damirka changed the title [WIP, RFC] Extending scope of the RFC to include proving system and curve [RFC] Extending scope of the RFC to include proving system and curve Jun 30, 2021
@damirka damirka added this to the Leo Developer Preview III milestone Jun 30, 2021
Copy link
Collaborator

@acoglio acoglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@gluax gluax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/rfc/003-imports-stabilization.md Outdated Show resolved Hide resolved
docs/rfc/003-imports-stabilization.md Outdated Show resolved Hide resolved
docs/rfc/003-imports-stabilization.md Outdated Show resolved Hide resolved
docs/rfc/003-imports-stabilization.md Outdated Show resolved Hide resolved
docs/rfc/003-imports-stabilization.md Outdated Show resolved Hide resolved
docs/rfc/003-imports-stabilization.md Outdated Show resolved Hide resolved
docs/rfc/003-imports-stabilization.md Outdated Show resolved Hide resolved
docs/rfc/003-imports-stabilization.md Outdated Show resolved Hide resolved
docs/rfc/003-imports-stabilization.md Outdated Show resolved Hide resolved
docs/rfc/003-imports-stabilization.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@bendyarm bendyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@acoglio acoglio merged commit b10343c into master Jul 2, 2021
@acoglio acoglio deleted the imports-stabilization branch July 2, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants