Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes assignment of mutable variable to mutable variable #466

Merged
merged 2 commits into from
Dec 8, 2020

Conversation

collinc97
Copy link
Collaborator

Motivation

Fixes #449

Test Plan

Test added for #449 example

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #466 (4cb07d5) into master (ced0246) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
+ Coverage   73.46%   73.48%   +0.02%     
==========================================
  Files         453      453              
  Lines       13483    13489       +6     
==========================================
+ Hits         9905     9913       +8     
+ Misses       3578     3576       -2     
Impacted Files Coverage Δ
compiler/src/value/value.rs 61.13% <100.00%> (+0.13%) ⬆️
compiler/tests/mutability/mod.rs 100.00% <100.00%> (ø)
type-inference/src/objects/frame.rs 89.70% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ced0246...4cb07d5. Read the comment docs.

@howardwu howardwu changed the title Fix/nested mut value Fixes assignment of mutable variable to mutable variable Dec 5, 2020
@howardwu howardwu merged commit f841f2e into master Dec 8, 2020
@collinc97 collinc97 deleted the fix/nested-mut-value branch January 26, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] assigning mutable variable to mutable variable causes "no implementation" when used in math
2 participants