Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Adds leo logout command #572

Merged
merged 1 commit into from
Jan 27, 2021
Merged

[CLI] Adds leo logout command #572

merged 1 commit into from
Jan 27, 2021

Conversation

damirka
Copy link
Contributor

@damirka damirka commented Jan 25, 2021

Motivation

Closes #363.

Allows using different accounts. Also helps testing by trying out logged out state.

Test Plan

Will do in CI, one #579 is accepted, or vice versa.

Related PRs

CI can be added into #579, this PR should be accepted first then.

@damirka damirka added the feature A new feature. label Jan 25, 2021
@damirka damirka self-assigned this Jan 25, 2021
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #572 (19d81c2) into master (dae45d9) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
- Coverage   74.73%   74.55%   -0.18%     
==========================================
  Files         472      472              
  Lines       13932    13932              
==========================================
- Hits        10412    10387      -25     
- Misses       3520     3545      +25     
Impacted Files Coverage Δ
leo/main.rs 100.00% <ø> (ø)
compiler/src/expression/arithmetic/mul.rs 0.00% <0.00%> (-23.81%) ⬇️
compiler/tests/integers/uint_macro.rs 93.40% <0.00%> (-3.30%) ⬇️
ast/src/expression/binary.rs 83.33% <0.00%> (-2.78%) ⬇️
compiler/src/value/integer/integer.rs 94.57% <0.00%> (-2.72%) ⬇️
grammar/src/ast.rs 94.38% <0.00%> (-1.13%) ⬇️
compiler/src/expression/expression.rs 95.83% <0.00%> (-0.84%) ⬇️
ast/src/expression/mod.rs 85.46% <0.00%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae45d9...19d81c2. Read the comment docs.

Copy link
Collaborator

@collinc97 collinc97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Please checkout a branch to impl logout ci check.

@damirka
Copy link
Contributor Author

damirka commented Jan 27, 2021

@collinc97 logout check implemented in #582, merging this one.

@damirka damirka merged commit 727981c into ProvableHQ:master Jan 27, 2021
@damirka damirka deleted the leo-cli-logout branch January 27, 2021 13:28
gluax pushed a commit that referenced this pull request Jan 27, 2021
bors bot added a commit that referenced this pull request Jan 29, 2021
582: [CLI, CI] Leo add does not require login r=collinc97 a=damirka

## Motivation

Leo add could be done without logging into Aleo PM. So token check is removed. That simplifies process for newcomers, and helps on CI stage - no need to add credentials.

## Test Plan

This PR includes changes to CI workflows: 
- login and logout have now their own workflow
- add, remove and clean are done without login

## Related PRs

This PR finalizes work on previous tasks:
- #572 
- #560

Co-authored-by: Damir Shamanaev <damirka.ru@gmail.com>
@damirka damirka mentioned this pull request Feb 22, 2021
9 tasks
@collinc97 collinc97 added this to the Leo Developer Preview II milestone Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Leo Logout
2 participants