-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] Adds leo logout command #572
Conversation
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
==========================================
- Coverage 74.73% 74.55% -0.18%
==========================================
Files 472 472
Lines 13932 13932
==========================================
- Hits 10412 10387 -25
- Misses 3520 3545 +25
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Please checkout a branch to impl logout ci check.
@collinc97 logout check implemented in #582, merging this one. |
582: [CLI, CI] Leo add does not require login r=collinc97 a=damirka ## Motivation Leo add could be done without logging into Aleo PM. So token check is removed. That simplifies process for newcomers, and helps on CI stage - no need to add credentials. ## Test Plan This PR includes changes to CI workflows: - login and logout have now their own workflow - add, remove and clean are done without login ## Related PRs This PR finalizes work on previous tasks: - #572 - #560 Co-authored-by: Damir Shamanaev <damirka.ru@gmail.com>
Motivation
Closes #363.
Allows using different accounts. Also helps testing by trying out logged out state.
Test Plan
Will do in CI, one #579 is accepted, or vice versa.
Related PRs
CI can be added into #579, this PR should be accepted first then.