-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Abstract Semantic Graph (ASG) - Base Implementation #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cargo +nightly clippy
Codecov Report
@@ Coverage Diff @@
## master #594 +/- ##
==========================================
+ Coverage 74.95% 76.45% +1.50%
==========================================
Files 477 571 +94
Lines 14031 19062 +5031
==========================================
+ Hits 10517 14574 +4057
- Misses 3514 4488 +974
Continue to review full report at Codecov.
|
collinc97
changed the title
Asg merge
[Feature] Abstract Syntax Graph (ASG) - Base Implementation
Feb 1, 2021
howardwu
approved these changes
Feb 1, 2021
collinc97
changed the title
[Feature] Abstract Syntax Graph (ASG) - Base Implementation
[Feature] Abstract Semantic Graph (ASG) - Base Implementation
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The primary motivation is to provide a cleaner, safer, and faster way to implement compiler passes. The ASG provides this by representing Leo programs by semantics rather than syntax.
This PR merges the changes from
asg-asg
andasg-comments
into the current master. Includes commits from #570 and #588.Huge shoutout to @Protryon for the colossal amount of work here.
Changes
Here is a list of current compiler issues that the ASG is targeted to resolve:
if else
scope. #377const
vars on non-const
vars is not rejected #514