Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mutable ConstrainedValue #601

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Remove mutable ConstrainedValue #601

merged 2 commits into from
Feb 3, 2021

Conversation

Protryon
Copy link
Contributor

@Protryon Protryon commented Feb 3, 2021

Relevant checks are handled by ASG and wrapper/modifier Enum pattern causes bugs. Fixes #583. Fixes #449.

@Protryon Protryon requested review from collinc97 and howardwu and removed request for collinc97 February 3, 2021 02:38
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #601 (abee766) into master (2657c44) will increase coverage by 0.15%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
+ Coverage   74.99%   75.14%   +0.15%     
==========================================
  Files         518      517       -1     
  Lines       16050    16021      -29     
==========================================
+ Hits        12036    12039       +3     
+ Misses       4014     3982      -32     
Impacted Files Coverage Δ
compiler/src/value/value.rs 53.21% <ø> (-0.96%) ⬇️
compiler/src/statement/assign/assignee.rs 73.03% <83.33%> (-0.93%) ⬇️
compiler/src/definition/definition.rs 100.00% <100.00%> (ø)
compiler/src/expression/array/access.rs 85.71% <100.00%> (ø)
compiler/src/expression/array/index.rs 80.00% <100.00%> (ø)
compiler/src/expression/binary/binary.rs 100.00% <100.00%> (ø)
compiler/src/expression/circuit/access.rs 46.15% <100.00%> (ø)
compiler/src/expression/conditional/conditional.rs 92.85% <100.00%> (ø)
compiler/src/expression/expression.rs 94.02% <100.00%> (+1.49%) ⬆️
compiler/src/expression/tuple/access.rs 77.77% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2657c44...abee766. Read the comment docs.

@howardwu howardwu merged commit 0e74f9e into master Feb 3, 2021
@Protryon Protryon deleted the remove-mutable-value branch February 3, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants