-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/254 strengthen import rules #620
Conversation
Codecov Report
@@ Coverage Diff @@
## master #620 +/- ##
==========================================
+ Coverage 75.63% 75.77% +0.13%
==========================================
Files 518 523 +5
Lines 16135 16199 +64
==========================================
+ Hits 12204 12275 +71
+ Misses 3931 3924 -7
Continue to review full report at Codecov.
|
grammar/src/leo.pest
Outdated
@@ -454,18 +454,25 @@ input_tuple = _{ "(" ~ (input ~ ("," ~ input)* ~ ","?)? ~ ")"} | |||
/// Imports | |||
|
|||
// Declared in imports/import.rs | |||
import = { "import " ~ package ~ LINE_END} | |||
import = { "import " ~ package_type ~ LINE_END} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might consider using package_or_packages
instead of package_type
, to avoid any potential confusion with Leo types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on this, it seems that could help improve readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I just left a very minor comment for consideration in the Pest file.
bors r+ |
598: [Feature] 374 circuit self access r=collinc97 a=gluax Feature resolves #374. At the grammar level the following syntax is no longer allowed on self: ``` self[0]; self(); ``` Syntax that is allowed at the grammar level is: ``` console.log("b: {}", self::b); console.log("hmm: {}",self::hmm()); self.hello(); console.log("access: {}", self.a); ``` Note that these changes are only at the grammar level only. 620: Feature/254 strengthen import rules r=collinc97 a=gluax Grammar changes are a bit different than what was suggested in the original feature request #254. However, it should be logically equivalent and I think makes more sense on the rust side. Closes #254 Co-authored-by: gluaxspeed <jonathan.t.pavlik@gmail.com> Co-authored-by: Howard Wu <9260812+howardwu@users.noreply.github.com>
bors r- |
Canceled. |
bors r+ |
Build succeeded: |
Grammar changes are a bit different than what was suggested in the original feature request #254. However, it should be logically equivalent and I think makes more sense on the rust side.
Closes #254