Skip to content

Commit

Permalink
search bar theming close enough
Browse files Browse the repository at this point in the history
Signed-off-by: Joseph Mattiello <git@joemattiello.com>

update todods

Signed-off-by: Joseph Mattiello <git@joemattiello.com>
  • Loading branch information
JoeMatt committed Nov 15, 2024
1 parent 3f86849 commit 741ced4
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 27 deletions.
19 changes: 19 additions & 0 deletions PVThemes/Sources/PVThemes/ThemeApplier.swift
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ public extension ThemeManager {
configureTabBar(palette)
configureTableViews(palette)
configureTextInputs(palette)
configureUISearchBar(palette)
configureUIView(palette)
configureUIWindow(palette)

Expand Down Expand Up @@ -182,8 +183,26 @@ public extension ThemeManager {
private class func configureTextInputs(_ palette: any UXThemePalette) {
UITextField.appearance().keyboardAppearance = palette.keyboardAppearance
UISearchBar.appearance().keyboardAppearance = palette.keyboardAppearance

UITextField.appearance().backgroundColor = palette.gameLibraryBackground
UITextField.appearance().textColor = palette.gameLibraryText

DLOG("Text inputs - keyboardAppearance: \(palette.keyboardAppearance)")
}

@MainActor
private class func configureUISearchBar(_ palette: any UXThemePalette) {
UISearchBar.appearance().backgroundColor = palette.menuBackground
UISearchBar.appearance().tintColor = palette.menuText
UISearchBar.appearance().barTintColor = palette.menuBackground
UISearchBar.appearance().searchTextField.textColor = palette.menuText
UISearchTextField.appearance().tokenBackgroundColor = palette.menuHeaderBackground
UISearchTextField.appearance().tintColor = palette.menuIconTint
UISearchTextField.appearance().textColor = palette.menuText

DLOG("UISearchBar - backgroundColor: \(palette.settingsCellBackground?.debugDescription ?? "nil"), tintColor: \(palette.gameLibraryText.debugDescription)")
}


@MainActor
private class func configureActionSheets(_ palette: any UXThemePalette) {
Expand Down
29 changes: 2 additions & 27 deletions TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,33 +3,7 @@ _My personal TODO notes_

## Show stoppers

- [X] RetroArch GLES cores are crashing?
- [X] moveable button joystick and dpad move at the same time
- [X] Delete isn't deleting
- [X] throw an error on file manager error
- [X] audio is fucked
- [X] 4X multisampling crashes Mupen on iPad, (iphone?)
- [X] Refresh library and conflicts on new UI not working
- [X] UI is unresponsive after closing emulator
- [X] wrap advanced settings in freemiumview
- [X] fix launching webserver from swiftui menu
- [X] iCloud sync isn't working, remove or fix
- [X] Swift UI long press on roms menu missing actions {rename, ~~share~~}
- [X] Progress hud on unzips isn't hiding
- [X] Themes setting doesn't work
- [X] Conflicts folder is weird
- [X] SwiftUI not seeing conflicts
- [X] Copy the framework loader from old branch, fix it too!
- [X] emuThreeDS and other metal based cores have wrong layout contraints
- [X] Possible race condition in importer
- [X] Gambatte swift module not done
- [X] PVmGBA swift module is not done
- [X] Fix Repo submodules
- [X] Audio broken
- [X] Loading save states crashes realm
- [X] Creating save states crashes realm
- [X] SwiftUI not importing roms correctly
- [X] compiling with Mupen+Rumble.swift breaks device release builds
- [ ] Shared documents : return FileManager.default.containerURL(forSecurityApplicationGroupIdentifier: PVAppGroupId)

## Major bugs

Expand Down Expand Up @@ -90,6 +64,7 @@ _My personal TODO notes_
- [ ] Game text not themed
- [ ] New import indicator not themed
- [ ] Make GameMoreInfoVC and it's equivlant PageViewController into native swifttUI with editing of properties
- [ ] App Group containers in Catalyst "public class var appGroupContainer"

## Cores to translate

Expand Down

0 comments on commit 741ced4

Please sign in to comment.