Post page UI foundation #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoannLafore
requested review from
JoachimFavre and
Aderfish
and removed request for
JoachimFavre
Aderfish
requested changes
Apr 25, 2024
lib/views/pages/post/post_page_widget/bottom_bar_add_comment.dart
Outdated
Show resolved
Hide resolved
|
Thank you @Aderfish for your comments 🎉 😄 |
There was a problem hiding this comment.
What a PR! This is the best PR I've seen of this project so far I think (after #111 of course), great job!
I've found so few things to say on the UI, that I have been very nitpicky. Those suggestions are very personal, and I'd understand you reject them.
I think my suggestions on the tests are more important but, even still, you have made a great job!
lib/views/pages/post/post_page_widget/bottom_bar_add_comment.dart
Outdated
Show resolved
Hide resolved
lib/views/pages/post/post_page_widget/bottom_bar_add_comment.dart
Outdated
Show resolved
Hide resolved
lib/views/pages/post/post_page_widget/complete_post_widget.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Joachim Favre <joachim@favre.xyz>
Co-authored-by: Joachim Favre <joachim@favre.xyz>
JoachimFavre
approved these changes
Apr 25, 2024
|
Very good changes! Just a small typo in a variable name but, apart from that, LGTM! Great job! :) |
|
Thank you @JoachimFavre for your review 🎉 😄 |
Aderfish
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR create the foundation for the post page UI.
Adds the post UI, comment and a text field that is always kept on screen (stay above the keyboard when opened).
It also adds the navigation from a post on the feed to this its post page
Current UI / Behavior of the post page using mock data:
Acceptance criteria: