-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calculate user visit count and save to redis #333
Conversation
1. Create new scheam 2. Record user visit action in loginRequiredPathProcess()
Codecov Report
@@ Coverage Diff @@
## main #333 +/- ##
==========================================
- Coverage 65.76% 65.59% -0.18%
==========================================
Files 142 145 +3
Lines 6926 6966 +40
==========================================
+ Hits 4555 4569 +14
- Misses 1644 1667 +23
- Partials 727 730 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Can you change schema/redis.go to schema/user_visit_count.go (like schema/lock.go)?
- Can you have
TIME_CALC_ALL_USER_VISIT_COUNTS = -10 * time.Minute
in schema/const.go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
這個 PR 的目的 / Purpose of this PR
相關的 issue / Related Issues
#263
TODO: