UOE-11149: Send Encoded SSPBurl in bid.Burl

PubMatic-OpenWrap · Sep 16, 2024 · eba1a60 · eba1a60
1 parent 5d3b3de
commit eba1a60
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/modules/pubmatic/openwrap/tracker/inject.go b/modules/pubmatic/openwrap/tracker/inject.go
@@ -3,6 +3,7 @@ package tracker
 import (
 	"errors"
 	"fmt"
+	"net/url"
 	"strings"
 
 	"golang.org/x/exp/slices"
@@ -91,5 +92,6 @@ func getBURL(burl, trackerURL string) string {
 		return trackerURL
 	}
 
-	return trackerURL + "&" + models.OwSspBurl + "=" + burl
+	escapedBurl := url.QueryEscape(burl)
+	return trackerURL + "&" + models.OwSspBurl + "=" + escapedBurl
 }
diff --git a/modules/pubmatic/openwrap/tracker/inject_test.go b/modules/pubmatic/openwrap/tracker/inject_test.go
@@ -1138,10 +1138,10 @@ func Test_getBurlAppLovinMax(t *testing.T) {
 		{
 			name: "valid_burl_and_tracker_url",
 			args: args{
-				burl:       `sampleBurl.com`,
+				burl:       `https://abc.xyz.com/AdServer/AdDisplayTrackerServlet?operId=1&pubId=161527&siteId=991727&adId=4695996&imprId=B430AE6F-4768-41D0-BC55-8CF9D5DD4DA6&cksum=41C0F6460C2ACF7F&adType=10&adServerId=243&kefact=0.095500&kaxefact=0.095500&kadNetFrequecy=0&kadwidth=300&kadheight=250&kadsizeid=9&kltstamp=1721827593&indirectAdId=0`,
 				TrackerURL: `sampleTracker.com?id=123`,
 			},
-			want: `sampleTracker.com?id=123&owsspburl=sampleBurl.com`,
+			want: `sampleTracker.com?id=123&owsspburl=https%3A%2F%2Fabc.xyz.com%2FAdServer%2FAdDisplayTrackerServlet%3FoperId%3D1%26pubId%3D161527%26siteId%3D991727%26adId%3D4695996%26imprId%3DB430AE6F-4768-41D0-BC55-8CF9D5DD4DA6%26cksum%3D41C0F6460C2ACF7F%26adType%3D10%26adServerId%3D243%26kefact%3D0.095500%26kaxefact%3D0.095500%26kadNetFrequecy%3D0%26kadwidth%3D300%26kadheight%3D250%26kadsizeid%3D9%26kltstamp%3D1721827593%26indirectAdId%3D0`,
 		},
 	}
 	for _, tt := range tests {