Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UOE-6319: Updated default usersync url for dmx #149

Merged
merged 95 commits into from
Apr 29, 2021
Merged

Conversation

sachin-pubmatic
Copy link

No description provided.

prebidtappx and others added 30 commits February 11, 2021 10:51
Co-authored-by: ubuntu <ahernandez@tappx.com>
Co-authored-by: Albert Grandes <agrandes@tappx.com>
* added place holder files for all but a couple of the intended new tests. I need to grok what those couple mean before being able to name a file.

* This covers most of the suggested cases and a couple more that occured to me. I'll look at the couple that I held off on next.

* added the unmarshal tests and found a couple problems to address in the process.

* removed my __debug_bin. should be in gitignore.

* A bit of clean up and commenting. Bumped version number. Added __debug_bin to .gitignore. This is the debugging binary created by Visual Studio Code, or at least version 1.52.1.

* missed a bunch of version strings

* removed IP faker

* If IP is not included in an AdM request, an error is now thrown for the AdM imp instead of faking it. The AdM endpoint is the only one that requires an IP. Also, added several "no-ip" test cases.

* Whent back to the fake IP solution instead of the error. Removed most of the "no-ip" test cases, leaving one.

* changed ip in adm-video.json to not match the faker ip

* removed a debugging comment
* Initial Commit

* Merge Conflict Fixes

* Removed Unncessary JSON Attributes

* Removed Dev Notes

* Add Missing validateDefaultAliases Test

* Improved Reversed Test

* Remove Var Scope Confusion

* Proper Tests For Bidder Param Validator

* Removed Unused Test Setup
Co-authored-by: Vasyl Zarva <vasyan.z@gmail.com>
Co-authored-by: hcai <caihengsheng@bytedance.com>
* adds pubId and irisid properties

* updates per naming convention & makes a video copy

* updates when to copy banner, adds Publisher fallback and multiformat request

* adds more json tests

* rename the json file to remove whitespaces
* initial commit

* added notes file for temp use

* jixie adapter development work

* jixie adaptor development work: mainly the test json files but also the jixie usersync code

* added a test case with accountid. and cosmetic line changes in the banner*json test file

* updated the jixie user sync: the endpoint and some params stuf

* tks and fixing per comments on pull request 1698

* responding to guscarreon's comments:
-more checking in makerequest of the bidder params (added 2 more test jsons)
-removed blank lines, lines commented out
-test_params: a case with unit alone
-BadInput error

* responding to review. put condition on jixie unit string in the bidder-params/jixie.json file.
removed checking in jixie.go that has become unnecssary. removed unnec test cases.
updated params-test

* added one failed params test

* removed a function that I no longer call!

* renamed JixieAdapter to adapter

* removed bidfloor from jixie explicit ext params
Co-authored-by: mobfox <artem.iholkin@smartyads.com>
* add bidder-info, bidder-params for UNICORN

* Add adapter
Co-authored-by: Damien Dumas <damien.dumas@adyoulike.com>
* No Longer Move bid.ext To bid.ext.bidder

* Remove Similar Behavior From seatbid.ext

* Avoid Second Bid Copy

* Removed Unused seatbid.ext
agilfix and others added 29 commits April 15, 2021 09:33
Remove definitions object from schema and define types and other parameters directly in properties objects to ensure compatibility with more downstream systems that use this schema.
Remove definitions object from schema and define types and other parameters directly in properties objects to ensure compatibility with more downstream systems that use this schema.
@sachin-pubmatic sachin-pubmatic merged commit 83ff771 into ci Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.