UOE-5310: Changes for optimization II #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShriprasadM
commented
Jun 9, 2020
There was a problem hiding this comment.
- To check if we can move to a new package - impressions. (Check for cyclic dependency)
- To check how can minimize the repetition of impression objects with the same duration. Approach
- Define constant - it will indicate how many repetitions are allowed
- Find how many maximum repetitions are required
| @@ -205,7 +204,8 @@ func fact(no uint64) big.Int { | |||
|
|
|||
| // wrapper around print function | |||
| func print(format string, v ...interface{}) { | |||
There was a problem hiding this comment.
use Logf instead print
| @@ -0,0 +1,478 @@ | |||
| // Package ctv provides functionalities for handling CTV specific Request and responses | |||
There was a problem hiding this comment.
To check if we can refactor this code.
| "github.com/PubMatic-OpenWrap/prebid-server/openrtb_ext" | ||
| ) | ||
|
|
||
| type config struct { |
There was a problem hiding this comment.
- add Algorithm - enum
- remove impressions structure
- define algorithm enum
UOE:5310 code review (#49)
PubMatic-OpenWrap
pushed a commit
that referenced
this pull request
Jun 24, 2020
This reverts commit af28a0f.
pm-viral-vala
pushed a commit
that referenced
this pull request
Jun 25, 2020
pm-viral-vala
added a commit
that referenced
this pull request
Jun 25, 2020
pm-nilesh-chate
pushed a commit
that referenced
this pull request
Jan 14, 2022
UOE-5310: Changes for optimization II (#48)
pm-nilesh-chate
pushed a commit
that referenced
this pull request
Jan 14, 2022
pm-nilesh-chate
pushed a commit
that referenced
this pull request
Jan 14, 2022
pm-nilesh-chate
pushed a commit
that referenced
this pull request
Jan 17, 2022
UOE-5310: Changes for optimization II (#48)
pm-nilesh-chate
pushed a commit
that referenced
this pull request
Jan 17, 2022
pm-nilesh-chate
pushed a commit
that referenced
this pull request
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.