DTS-38481:Read exception should fail processing | <Release 10.1.0>

processors/jira/src/main/java/com/publicissapient/kpidashboard/jira/service/JiraCommonService.java

@@ -154,6 +154,9 @@ public String getDataFromServer(URL url, Optional<Connection> connectionOptional
 			request.setRequestProperty("Authorization", "Basic " + encodeCredentialsToBase64(username, password)); // NOSONAR
 		}
 		request.connect();
+		int responseCode = request.getResponseCode();
+		// process the client error
+		processClientError(connectionOptional, responseCode, request);
 		StringBuilder sb = new StringBuilder();
 		try (InputStream in = (InputStream) request.getContent();
 				BufferedReader inReader = new BufferedReader(new InputStreamReader(in, StandardCharsets.UTF_8))) {
@@ -174,6 +177,42 @@ public String getDataFromServer(URL url, Optional<Connection> connectionOptional
 		return sb.toString();
 	}
 
+	/**
+	 * Method to process client error and update the connection broken flag
+	 * 
+	 * @param connectionOptional
+	 *            connectionOptional
+	 * @param responseCode
+	 *            responseCode
+	 * @param request
+	 *            request
+	 * @throws IOException
+	 *             throw IO Error
+	 */
+	private void processClientError(Optional<Connection> connectionOptional, int responseCode,
+			HttpURLConnection request) throws IOException {
+		if (responseCode >= 400 && responseCode < 500) {
+			// Read error message from the server
+			InputStream errorStream = request.getErrorStream();
+			BufferedReader reader = new BufferedReader(new InputStreamReader(errorStream));
+			StringBuilder response = new StringBuilder();
+			String line;
+			while ((line = reader.readLine()) != null) {
+				response.append(line);
+			}
+			reader.close();
+			request.disconnect();
+			// flagging the breaking connection
+			connectionOptional.ifPresent(connection -> {
+				String errMsg = ClientErrorMessageEnum.fromValue(responseCode).getReasonPhrase();
+				processorToolConnectionService.updateBreakingConnection(connection.getId(), errMsg);
+			});
+			// Throw an exception with the error message
+			log.error("Exception when reading from server {}", response);
+			throw new IOException(String.format("Error: %d - %s", responseCode, response));
+		}
+	}
+
 	/**
 	 * 
 	 * @param connectionOptional

processors/jira/src/test/java/com/publicissapient/kpidashboard/jira/service/JiraCommonServiceTest.java

@@ -44,6 +44,7 @@
 import java.util.Map;
 import java.util.Optional;
 
+import org.bson.types.ObjectId;
 import org.codehaus.jettison.json.JSONException;
 import org.codehaus.jettison.json.JSONObject;
 import org.joda.time.DateTime;
@@ -225,8 +226,10 @@ public void getVersionTest() throws IOException, ParseException {
 		HttpURLConnection mockedConnection = Mockito.mock(HttpURLConnection.class);
 		String responseData = "Sample response data";
 		InputStream inputStream = new ByteArrayInputStream(responseData.getBytes(StandardCharsets.UTF_8));
-		List<ProjectVersion> versions = jiraCommonService.getVersion(projectConfFieldMapping1, krb5Client);
-		Assert.assertEquals(0, versions.size());
+		assertThrows(IOException.class, () -> {
+			jiraCommonService.getVersion(projectConfFieldMapping1, krb5Client);
+		});
+//		Assert.assertEquals(0, versions.size());
 	}
 	// @Test(expected = RestClientException.class)
 	// public void getVersionTest1() throws IOException, ParseException {
@@ -495,4 +498,31 @@ public void testSaveSearchDetailsInContext() {
 		// Assert
 		verify(mockExecutionContext).putInt(JiraConstants.TOTAL_ISSUES, totalIssues);
 		verify(mockExecutionContext).putInt(JiraConstants.PAGE_START, pageStart);
+	}
+
+	@Test
+	public void testProcessClientError() throws IOException {
+		// Arrange
+		int responseCode = 404;
+		String errorMessage = "Not Found";
+
+		HttpURLConnection mockConnection = Mockito.mock(HttpURLConnection.class);
+		when(mockConnection.getResponseCode()).thenReturn(responseCode);
+		when(mockConnection.getErrorStream()).thenReturn(new ByteArrayInputStream(errorMessage.getBytes(StandardCharsets.UTF_8)));
+
+		URL mockUrl = Mockito.mock(URL.class);
+		when(mockUrl.openConnection()).thenReturn(mockConnection);
+
+		Connection mockConnectionObject = Mockito.mock(Connection.class);
+		when(mockConnectionObject.getId()).thenReturn(new ObjectId("668517f812811950be19353f"));
+		Optional<Connection> connectionOptional = Optional.of(mockConnectionObject);
+
+		// Act
+		Exception exception = assertThrows(IOException.class, () -> {
+			jiraCommonService.getDataFromServer(mockUrl, connectionOptional);
+		});
+
+		// Assert
+		String expectedMessage = "Error: 404 - Not Found";
+		assertEquals(expectedMessage, exception.getMessage());
 	}}