Pub 2941 fixing missing logging of invalid bids

[nathan-pubx]

Ticket: PUB-2941

This ticket addresses an issue in which an auction containing only invalid bids is not recorded.

Invalid bids are mapped to bidtype 1. Timed-out bids are mapped to bidtype 3. If any auction contains only bidtypes 1 or 3, it is now sent to pubx (assuming the relevant downsampling permits this).

There was a query as to whether or not auctions. with no bids at all were recorded. using the javascript array.prototype.every function on an empty array returns true, so this condition is satisfied. An additional test already verified this in prebid, but the test was quite obscure, so i tried to tidy it up a little.

Additional tests were added to confirm that auctions with timed out bids or invalid bids (as far as i can tell this only occurs due to pricing issues) are also recorded.

[github-actions]

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

• modules/radsBidAdapter.js has 19 duplicated lines with libraries/dspxUtils/bidderUtils.js
• modules/radsBidAdapter.js has 26 duplicated lines with libraries/dspxUtils/bidderUtils.js
• modules/omsBidAdapter.js has 10 duplicated lines with modules/onomagicBidAdapter.js
• modules/carodaBidAdapter.js has 17 duplicated lines with modules/dianomiBidAdapter.js
• modules/adtrgtmeBidAdapter.js has 36 duplicated lines with modules/yahooAdsBidAdapter.js
• modules/adfBidAdapter.js has 27 duplicated lines with modules/dianomiBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

[pnhegde]

@nathan-pubx It's showing all other non-related commits in this PR. Could you please rebase the upstream master before adding this commit to avoid duplicate commits?

[nathan-pubx]

@nathan-pubx It's showing all other non-related commits in this PR. Could you please rebase the upstream master before adding this commit to avoid duplicate commits?

Sorry @pnhegde , that's done now. The branch was based on the prebid.js master branch, but now is based on the pubx master