Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --module-name to keygen #10

Merged
merged 3 commits into from
Mar 25, 2024
Merged

add --module-name to keygen #10

merged 3 commits into from
Mar 25, 2024

Conversation

kamiyaa
Copy link
Contributor

@kamiyaa kamiyaa commented Mar 23, 2024 •
edited
Loading

also update ABIs and version to keygen response.

Version is based on version in Cargo.toml (currently 0.1.0)

@kamiyaa kamiyaa requested a review from JasonVranek March 24, 2024 00:21
@kamiyaa kamiyaa changed the title add --module-name to coral-cli add --module-name to keygen Mar 24, 2024
@kamiyaa kamiyaa requested a review from lean-apple March 24, 2024 00:23
lean-apple
lean-apple approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@lean-apple lean-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test both cases, works fine

@kamiyaa kamiyaa merged commit df10589 into main Mar 25, 2024
1 check passed
@kamiyaa kamiyaa deleted the fixes branch March 25, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lean-apple lean-apple lean-apple approved these changes

@JasonVranek JasonVranek Awaiting requested review from JasonVranek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamiyaa @lean-apple