Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sign_voluntary_exit_message command #7

Merged
merged 12 commits into from
Feb 26, 2024
Merged

Conversation

lean-apple
Copy link
Contributor

@lean-apple lean-apple commented Feb 23, 2024

Add sign-voluntary-exit command to be used like this :

cargo run --bin coral-cli validator sign-voluntary-exit \
  --bls-public-key 0x94505f60bb8e48ddafb8835ec08537c48ed1bb9bc6a95fe941f37869b5eb0950c9023b7a997fe12d8aa79076561e009f \
  --beacon-index 1605300 \
  --enclave-url http://localhost:9001 \
  --fork-previous-version 0x04017000 \
  --fork-current-version 0x05017000 \
  --epoch 29696 \
  --genesis-validators-root 0x9143aa7c615a7f7115e2b6aac319c03529df8242ae705fba9df39b79c59fa8b1 \
  --output-file sign_vem_001.json

File output format :

{
  "signature": "0xb3ace343a1fa578429d171526d2a318298b00d5b4dca4212aac374b61eb8436ccdb363c823fb3c75b504cc17a023b00808d6cad733215c39da71339f49047e103df7bf072fc0fbf4f5cda3a9fa21c03a68a93326669bb657e8a1af22bff00670",
  "beacon_index": 1605300,
  "epoch": 29696,
  "bls_pubkey": "0x94505f60bb8e48ddafb8835ec08537c48ed1bb9bc6a95fe941f37869b5eb0950c9023b7a997fe12d8aa79076561e009f"
}

yet @kamiyaa just wondering if we keep the beacon_client part in this new coral,
Here we just use it to get beacon_index, I don't think it's so annoying to push as an argument in the command instead

  • Remove all beacon part and move beacon_index as a command arg
  • Test with validator_enclave
  • Docs

Next step : integrate to broadcast in front-end

@lean-apple lean-apple marked this pull request as draft February 23, 2024 17:33
@lean-apple lean-apple requested a review from kamiyaa February 26, 2024 18:14
@lean-apple lean-apple marked this pull request as ready for review February 26, 2024 18:14
@kamiyaa kamiyaa merged commit fb183c1 into main Feb 26, 2024
1 check passed
@lean-apple lean-apple deleted the feature/sign-vem-command branch March 20, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants