Uncaught TypeError: Cannot read property 'dispose' of undefined #67

YurySolovyov · 2015-05-08T09:03:55Z

`TEMPORARY WORKAROUND:`

`$ apm install highlight-selected@0.9.1`

open Atom
try to open any file

Atom Version: 0.199.0-fabfd2a
System: linux 3.13.0-52-generic
Thrown From: highlight-selected package, v0.9.2

Stack Trace

Uncaught TypeError: Cannot read property 'dispose' of undefined

At /usr/local/share/atom/resources/app.asar/node_modules/event-kit/lib/composite-disposable.js:25

TypeError: Cannot read property 'dispose' of undefined
    at /usr/local/share/atom/resources/app.asar/node_modules/event-kit/lib/composite-disposable.js:25:28
    at Set.forEach (native)
    at CompositeDisposable.module.exports.CompositeDisposable.dispose (/usr/local/share/atom/resources/app.asar/node_modules/event-kit/lib/composite-disposable.js:24:26)
    at MinimapHighlightSelectedView.module.exports.HighlightedAreaView.subscribeToActiveTextEditor (/home/user/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:60:15)
    at /home/user/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:33:24
    at Emitter.module.exports.Emitter.emit (/usr/local/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
    at /usr/local/share/atom/resources/app.asar/src/pane-container.js:343:34
    at Emitter.module.exports.Emitter.emit (/usr/local/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
    at Pane.module.exports.Pane.setActiveItem (/usr/local/share/atom/resources/app.asar/src/pane.js:234:22)
    at Pane.module.exports.Pane.removeItem (/usr/local/share/atom/resources/app.asar/src/pane.js:368:16)

Commands

     -0:35.3.0 fuzzy-finder:toggle-file-finder (atom-pane.pane.active)
     -0:32.9.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:19.1.0 fuzzy-finder:toggle-file-finder (atom-pane.pane.active)
     -0:16.2.0 core:confirm (atom-text-editor.editor.mini.is-focused)

Config

{
  "core": {
    "audioBeep": false,
    "disabledPackages": [
      "release-notes"
    ],
    "autoHideMenuBar": true
  },
  "highlight-selected": {
    "onlyHighlightWholeWords": true
  }
}

Installed Packages

# User
highlight-selected, v0.9.2
language-javascript-better, v1.5.0
minimap, v4.8.0
minimap-highlight-selected, v4.2.1

# Dev
No dev packages

The text was updated successfully, but these errors were encountered:

Because Set.prototype.forEach() can returns undefined, see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/forEach, and this issue: Pulsar-Edit-Highlights/selected#67.

v3ss0n · 2015-05-11T06:12:47Z

Same here.

open atom
Clicking any tab.

Fixes Pulsar-Edit-Highlights/selected#67

abe33 · 2015-05-11T09:36:05Z

Ok, so the problem is much complex than I thought, looks like the fix doesn't really work for the first editor opened in a pane (the tab is visible, but the editor content doesn't show up).

For the time being, I recommend turning the minimap-highlight-selected plugin off.

@richrace Maybe it's time to think of a service for highlight-selected so that I don't have to patch the view the way I do?

YurySolovyov · 2015-05-11T09:39:05Z

For the time being, I recommend turning the minimap-highlight-selected plugin off.

That's what I've done

richrace · 2015-05-11T09:51:26Z

Hmm, I don't get this in Mac with Atom 0.198.0. Everything seems to be working fine.

@abe33 I agree. I'll see what I can do this week.

abe33 · 2015-05-11T10:54:49Z

Looks like the issue is also triggered when the minimap plugin is disabled:

Here's the stack:

TypeError: Cannot read property 'dispose' of undefined
  at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/composite-disposable.js:25:28
  at Set.forEach (native)
  at CompositeDisposable.module.exports.CompositeDisposable.dispose (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/composite-disposable.js:24:26)
  at HighlightedAreaView.module.exports.HighlightedAreaView.subscribeToActiveTextEditor (/Users/cedric/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:27:29)
  at /Users/cedric/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:13:8
  at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/pane-container.js:343:34
  at Pane.module.exports.Pane.observeActiveItem (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:182:7)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/pane-container.js:342:42
  at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
  at PaneContainer.module.exports.PaneContainer.setActivePane (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-container.js:218:22)
  at Pane.module.exports.Pane.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:607:15)
  at Pane.module.exports.Pane.focus (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:193:21)
  at atom-pane.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-element.js:59:23)

For me these lines should be written like this instead:

if editor = @getActiveEditor()
  @selectionSubscription.add editor.onDidAddSelection =>
    @handleSelection()
  @selectionSubscription.add editor.onDidChangeSelectionRange =>
    @handleSelection()

Because in the current version, when the text editor doesn't exist, undefined is added to the composite disposable.

abe33 · 2015-05-11T12:50:59Z

I omitted to give the Atom version: 0.199.0-f1f8c3d (freshly built from master this morning).

v3ss0n · 2015-05-11T13:56:00Z

yes , happen to me on 0.199.0-f1f8c3d too , i skipped 197 and 198.

stramel · 2015-05-11T15:30:25Z

I am getting this as well

OS: Ubuntu 14.04
Atom version: 0.199.0-f1f8c3d
highlight-selected: 0.9.2

kolAflash · 2015-05-11T16:33:00Z

No bug with:
Atom: 0.196.0
highlight-selected package: 0.9.2

Bug reproducibly appears with:
Atom: 0.198.0
highlight-selected package: 0.9.2
Steps to reproduce:

open settings
close settings
bug appears

My OS: openSUSE Linux 13.2 (Kernel 3.16.7)

yar0d · 2015-05-12T09:53:00Z

I'm having trouble too with Atom 0.198.0/highlight-selected 0.9.2 on Arch Linux when I open Atom and click a tab. I've removed highlight-selected and disabled minimap-highlight-selected plugins to work with Atom.

YurySolovyov · 2015-05-12T10:51:24Z

I've just rolled back package versions and it works fine:

$ apm install highlight-selected@0.9.1
Installing highlight-selected@0.9.1 to /home/user/.atom/packages ✓
$ apm install minimap-highlight-selected@4.2.3
Installing minimap-highlight-selected@4.2.3 to /home/user/.atom/packages ✓
$ atom -v
0.199.0-ccc6b17

kolAflash · 2015-05-12T13:03:20Z

Going back to highlight-selected@0.9.1 helped for me too. Must be something changed between 0.9.1 and 0.9.2!

v3ss0n · 2015-05-12T14:16:42Z

Yes going back to 0.9.1 fixed it! thank you @YuriSolovyov for discovering that!
Going to compare diffs.

shaungrady · 2015-05-14T23:57:42Z

I'm getting this error in Atom 0.199.0 by opening the Settings and then closing the the Settings tab. The error is thrown and Settings remains open. I never saw this error before updating to 0.199.0. On OS X.

190n · 2015-05-15T00:45:55Z

Also getting this on Atom 0.199, Ubuntu 14.10.

refrain4121 · 2015-05-15T02:12:25Z

Get this problem too on Atom 0.199, Windows.

xpol · 2015-05-15T06:46:16Z

Enabled highlight-selected.
Restart Atom,
Add a project folder to tree view (this make it easy to open a file).
Close all tabs
Open a file by double click items in the tree view.

Got: the file can't open, just the tab shows up.

And disable highlight-selected, try again, then the first file opens both tab and editor view shows.

I have tested both Windows 7 and Mac OSX.

v3ss0n · 2015-05-15T07:00:02Z

current work around is to downgrade to highlight-select to version 0.9.1 using apm as discovered by
@YuriSolovyov

$ apm install highlight-selected@0.9.1

Yuri , can you edit that work around for newcomers in your op ?

YurySolovyov · 2015-05-15T07:12:43Z

@v3ss0n sure, thanks for the tip

fix #67

YurySolovyov · 2015-05-15T08:17:16Z

Works just fine, thanks.

kmyl mentioned this issue May 10, 2015

dispose() of undefined atom/event-kit#10

Closed

abe33 added a commit to atom-minimap/minimap-highlight-selected that referenced this issue May 11, 2015

🐛 Prevent error raised when disposing the view

333e7d8

Fixes Pulsar-Edit-Highlights/selected#67

YurySolovyov mentioned this issue May 12, 2015

Feature Request: finer package controls atom/apm#157

Open

willdady mentioned this issue May 15, 2015

Atom slow to open + tabs broken (0.199.0 Mac) atom/atom#6791

Closed

richrace closed this as completed in 12035dd May 15, 2015

richrace added a commit that referenced this issue May 15, 2015

Merge pull request #68 from yongkangchen/patch-2

6dd42ac

fix #67

richrace mentioned this issue May 20, 2015

An error message shows up with no obvious abnormal behavior #70

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uncaught TypeError: Cannot read property 'dispose' of undefined #67

Uncaught TypeError: Cannot read property 'dispose' of undefined #67

YurySolovyov commented May 8, 2015

v3ss0n commented May 11, 2015

abe33 commented May 11, 2015

YurySolovyov commented May 11, 2015

richrace commented May 11, 2015

abe33 commented May 11, 2015

abe33 commented May 11, 2015

v3ss0n commented May 11, 2015

stramel commented May 11, 2015

kolAflash commented May 11, 2015

yar0d commented May 12, 2015

YurySolovyov commented May 12, 2015

kolAflash commented May 12, 2015

v3ss0n commented May 12, 2015

shaungrady commented May 14, 2015

190n commented May 15, 2015

refrain4121 commented May 15, 2015

xpol commented May 15, 2015

v3ss0n commented May 15, 2015

YurySolovyov commented May 15, 2015

YurySolovyov commented May 15, 2015

Uncaught TypeError: Cannot read property 'dispose' of undefined #67

Uncaught TypeError: Cannot read property 'dispose' of undefined #67

Comments

YurySolovyov commented May 8, 2015

TEMPORARY WORKAROUND:

$ apm install highlight-selected@0.9.1

Stack Trace

Commands

Config

Installed Packages

v3ss0n commented May 11, 2015

abe33 commented May 11, 2015

YurySolovyov commented May 11, 2015

richrace commented May 11, 2015

abe33 commented May 11, 2015

abe33 commented May 11, 2015

v3ss0n commented May 11, 2015

stramel commented May 11, 2015

kolAflash commented May 11, 2015

yar0d commented May 12, 2015

YurySolovyov commented May 12, 2015

kolAflash commented May 12, 2015

v3ss0n commented May 12, 2015

shaungrady commented May 14, 2015

190n commented May 15, 2015

refrain4121 commented May 15, 2015

xpol commented May 15, 2015

v3ss0n commented May 15, 2015

YurySolovyov commented May 15, 2015

YurySolovyov commented May 15, 2015

`TEMPORARY WORKAROUND:`

`$ apm install highlight-selected@0.9.1`