Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves behavior when multiple attempts are made to remove one or all ViewModels #31

Merged
merged 7 commits into from
May 26, 2024

Conversation

michaelpduda
Copy link
Member

  1. In the samples, adds a confirmation popup to the shared lists for manual testing.
  2. Re-arranges the test project namespaces and folders.
  3. Prevents the UpbeatStack from attempting to remove a ViewModel more than one time at once when it has called RegisterCloseCallback. Now, the first attempt will execute and any subsequent attempts while the close callback is still running will be ignored.
  4. Improves the CanExecute behavior for the RemoveTopViewModelCommand by also checking if that ViewModel is currently running a close callback.
  5. When attempting to close all ViewModels, will now wait for any already running close callbacks to complete.

@michaelpduda michaelpduda merged commit bb2c53d into main May 26, 2024
@michaelpduda michaelpduda deleted the RemoveVMsFixes branch May 26, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant