Fix top option not working #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes! Thank you! Will get this deployed to production shortly. |
|
This has been deployed to production. Apologies for the delay! |
|
No problem, thanks for the update! |
haydenmc
added a commit
that referenced
this pull request
Apr 28, 2024
Recently the Purdue.io front-end started showing timeouts when browsing the Class list page for a particular Course. Investigation revealed expensive SQL queries being generated, taking upwards of a minute to complete. Analysis revealed this section was contributing most of the cost of the query, requiring sequential evaluation of rows from disk: ```sql SELECT t8."Id", t8."Email", t8."Name", t8."MeetingId", t8."InstructorId" FROM ( SELECT i."Id", i."Email", i."Name", m0."MeetingId", m0."InstructorId", ROW_NUMBER() OVER(PARTITION BY m0."MeetingId" ORDER BY i."Id") AS row FROM "MeetingInstructor" AS m0 INNER JOIN "Instructors" AS i ON m0."InstructorId" = i."Id" ) AS t8 WHERE t8.row <= $7 ``` Further investigation revealed that this was due to pagination logic being applied to the `$expand` operation. An issue is open with a similar repro here: OData/AspNetCoreOData#1041 The pagination logic was being applied due to the recent change #65. This PR reverts that change to fix the performance regression until a workaround is provided by the OData library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62
Tested that using $top > 0 works now
I'm assuming
.Page()should've been uncommented after the issue was fixed in .NET 6?