Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Added Class of Device #103

Closed
wants to merge 5 commits into from
Closed

[WIP] Added Class of Device #103

wants to merge 5 commits into from

Conversation

carlos21
Copy link
Contributor

@carlos21 carlos21 commented Aug 1, 2018 •
edited
Loading

Issue

#102.

What does this PR Do?

Added Class of Device structure. I'll add more tests tomorrow.

Where should the reviewer start?

ClassOfDevice.swift

@carlos21 carlos21 changed the title [WIP] #102 Added Class of Device [WIP] Added Class of Device Aug 1, 2018
@carlos21
#102 importing Foundation, fix for swift 3
f48e8c1
@carlos21
#102
e218c10 
* added FormatType struct,
* added data encoding for ClassOfDevice
@carlos21
#102
f554877 
added tests (ClassOfDevice)
fixed 1 encoding bug (ClassOfDevice)
@carlos21 carlos21 self-assigned this Aug 1, 2018
@colemancda
Copy link
Member

Result of Integration 1

Duration: 1 minute and 1 second
Result: -1 error, failing state: checkout-error

@colemancda
Copy link
Member

Already merged into #99 .

@colemancda colemancda closed this Aug 13, 2018
@colemancda colemancda deleted the feature/add-class-of-device branch October 31, 2018 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colemancda colemancda Awaiting requested review from colemancda

Assignees

@carlos21 carlos21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlos21 @colemancda