Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #359: Option to use non-global Electron #367

Merged
merged 1 commit into from
Apr 30, 2022

Conversation

davesmith00000
Copy link
Member

@davesmith00000 davesmith00000 commented Apr 30, 2022

This PR adds a new configuration option to the Indigo plugin (both Mill and sbt) to change how Electron is installed and invoked, like this (Mill shown here):

// (Pick one...) 
val electronInstall = ElectronInstall.Latest // will install and use version 18.0.0+
val electronInstall = ElectronInstall.Version("^17.0.0") // will install and use 17.0.0+
val electronInstall = ElectronInstall.Global // will use the globally installed version
val electronInstall = ElectronInstall.PathToExecutable(path) // Assumes you know what you're doing...

Defaults to global for two reasons:

  1. Doesn't break existing experience
  2. Local installs are slower and rather inefficient

Regarding the inefficiency, there might be a future piece of work to make all this significantly more performant, but I decided not to do that yet - if anyone wants it I'm sure an issue can be raised. Essentially if we build the npm deps as part of the build DAG then it can be cached and reused.

@davesmith00000 davesmith00000 requested a review from a team April 30, 2022 10:04
@davesmith00000 davesmith00000 self-assigned this Apr 30, 2022
@davesmith00000 davesmith00000 force-pushed the plugin-electron-install-types branch from dfc9281 to 8c8123f Compare April 30, 2022 20:03
@davesmith00000 davesmith00000 merged commit f96a9ba into main Apr 30, 2022
@davesmith00000 davesmith00000 deleted the plugin-electron-install-types branch April 30, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant