Fixed #359: Option to use non-global Electron #367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new configuration option to the Indigo plugin (both Mill and sbt) to change how Electron is installed and invoked, like this (Mill shown here):
Defaults to global for two reasons:
Regarding the inefficiency, there might be a future piece of work to make all this significantly more performant, but I decided not to do that yet - if anyone wants it I'm sure an issue can be raised. Essentially if we build the npm deps as part of the build DAG then it can be cached and reused.