Add ability to customize html background color #386
Conversation
zikolach
force-pushed
the
feature/background-color
branch
from
fab5d19
to
83f7ff8
Compare
|
@davesmith00000 could you please have a look? I made changes according to your suggestions. Switching white to black really hurts the eyes when reloading page during development 👓 |
|
Thanks, will do! I can't review this properly today but I'll have a look soon! The thing that stands out after a quick glance is the default "white" value on the case class. I don't normally do that - but it might be ok when I have time to look at it properly in context. |
| @@ -2,7 +2,7 @@ package indigoplugin.templates | |||
|
|
|||
| object HtmlTemplate { | |||
|
|
|||
| def template(title: String, showCursor: Boolean, scriptName: String): String = | |||
| def template(title: String, showCursor: Boolean, scriptName: String, backgroundColor: String): String = | |||
There was a problem hiding this comment.
I feel like this methods signature should now be:
def template(scriptName: String, templateOptions: TemplateOptions): StringOtherwise we're just expanding the fields of the case class into function arguments?
| @@ -6,7 +6,8 @@ final case class TemplateOptions( | |||
| title: String, | |||
| showCursor: Boolean, | |||
| scriptPathBase: Path, | |||
| gameAssetsDirectoryPath: Path | |||
| gameAssetsDirectoryPath: Path, | |||
| backgroundColor: String = "white" | |||
There was a problem hiding this comment.
Do we need the default? Can it be removed? I suspect it's unnecessary? SBT will default to white and Mill forces you to provide a value.
| val showCursor: SettingKey[Boolean] = settingKey[Boolean]("Show the cursor? True by default.") | ||
| val title: SettingKey[String] = settingKey[String]("Title of your game. Defaults to 'Made with Indigo'.") | ||
| val backgroundColor: SettingKey[String] = | ||
| settingKey[String]("HTML page background color CSS property. Defaults to 'initial'.") |
There was a problem hiding this comment.
Description says 'initial' but line 48 sets it to 'white'.
It is useful while developing a game with dark background (to avoid showing white empty HTML page on browser reloads).