Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Indigo Shaders from GLSL to Ultraviolet #444

Merged
merged 54 commits into from
Feb 12, 2023
Merged

Conversation

davesmith00000
Copy link
Member

No description provided.

@davesmith00000 davesmith00000 requested a review from a team November 29, 2022 08:36
@davesmith00000 davesmith00000 self-assigned this Nov 29, 2022
@davesmith00000
Copy link
Member Author

Ah yeah, the build is going to fail until I publish Ultraviolet.

Chicken and egg, I need to do enough of this work to prove UV is ready for release. Works just fine locally.

@davesmith00000
Copy link
Member Author

Ported ImageEffects, once again, worked first time...
image

@davesmith00000
Copy link
Member Author

Quick update:
There are only three 'library' shaders left to port: ShapeBox, ShapeCircle, and ShapePolygon.

After that, a decision needs to be made about the 'base' template shaders, and if (:crossed_fingers:) they are/can be replaced, then the GLSL lang validator and all the shader code gen can also be removed.

@davesmith00000
Copy link
Member Author

I think this is ready, but I need to cut a release of Ultraviolet to prove it works...

@davesmith00000
Copy link
Member Author

The build is green!

...but I've thought of more things to do:

  1. The standard shaders are still using the old GLSL bases.
  2. The new UV shader bases still contain the lighting stuff... but that isn't used.

@davesmith00000 davesmith00000 marked this pull request as ready for review February 11, 2023 22:10
@davesmith00000 davesmith00000 merged commit be8e317 into main Feb 12, 2023
@davesmith00000 davesmith00000 deleted the ultraviolet branch February 12, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant