Fixed #461: Best effort to match target framerate #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davesmith00000
force-pushed
the
issue/461/smoother-framerate-limiter
branch
from
2d8cc64
to
1ccd7dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So after all the back and forth, I seem to have a solution.
It isn't a perfect solution, but it appears to allow Indigo to more closely meet the desired framerate.
The advice to try not to rely on this remains. However rather than (on this machine) a frame rate of 144fps being asked to constrain to 60fps and actually being 48fps, it is now 64fps which is much more acceptable.
Essentially I'm tracking the mean frame delta and using that to guess if we're likely to overshoot on the next update, and taking corrective action.
Will it work nicely across all platforms? Time will tell.