Fix Gamepad handling when only one axis is present #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... in particular, a single connected Joy-Con. Fixes PurpleKingdomGames#760
davesmith00000
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
@sherpal - Very sorry this took such a long time to review! Looks great, many thanks. 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in particular, a single connected Joy-Con.
Fixes #760
I imagine we could go one step further and handle the hypothetical case where there is 0 axis (They seem to exist*). But as I don't own one, I can't verify whether it would actually translate to the axes array to be of length 0. So I would leave it like that for now.